Try/catch ResetConnectionAsync (works around #208) #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ConnectionPool is asked for a session, depending on server version, it will attempt to reauthenticate. On occasion the server will close the connection and the next read from the stream will be 0 bytes, causing the connection to fail. This PR wraps ResetConnectionAsync in a try/catch, and if it throws it will fall back to instantiating a new MySqlSession.
I'm not sure if we should be trying to catch only certain exceptions (EndOfStreamException?) and let others bubble up as usual.