Skip to content

Support the CLIENT_DEPRECATE_EOF flag #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2017

Conversation

bgrainger
Copy link
Member

Fixes #322.

Will test as a possible workaround for #267. Even if it doesn't fix that issue, it will be slightly more efficient as it transmits fractionally fewer bytes over the wire when processing a result set.

This prevents the session from being returned to the pool with potentially-unread data on the network socket.
As soon as a malformed column_count packet is detected, throw a descriptive exception (instead of failing at an arbitrary point later during deserialization).
This library doesn't actually implement support for CLIENT_PS_MULTI_RESULTS.
@bgrainger bgrainger merged commit db3a608 into mysql-net:master Sep 7, 2017
@bgrainger bgrainger deleted the deprecate-eof branch September 7, 2017 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Implement CLIENT_DEPRECATE_EOF
1 participant