Skip to content

Commit 4169a0e

Browse files
committed
Make ExecuteReaderAsync an async method.
This may be needed for New Relic instrumentation to function correctly.
1 parent 495c092 commit 4169a0e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/MySqlConnector/MySql.Data.MySqlClient/MySqlCommand.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,13 +261,13 @@ protected override Task<DbDataReader> ExecuteDbDataReaderAsync(CommandBehavior b
261261
return ExecuteReaderAsync(behavior, AsyncIOBehavior, cancellationToken);
262262
}
263263

264-
internal Task<DbDataReader> ExecuteReaderAsync(CommandBehavior behavior, IOBehavior ioBehavior, CancellationToken cancellationToken)
264+
internal async Task<DbDataReader> ExecuteReaderAsync(CommandBehavior behavior, IOBehavior ioBehavior, CancellationToken cancellationToken)
265265
{
266266
if (!IsValid(out var exception))
267-
return Utility.TaskFromException<DbDataReader>(exception);
267+
throw exception;
268268

269269
m_commandBehavior = behavior;
270-
return CommandExecutor.ExecuteReaderAsync(new IMySqlCommand[] { this }, SingleCommandPayloadCreator.Instance, behavior, ioBehavior, cancellationToken);
270+
return await CommandExecutor.ExecuteReaderAsync(new IMySqlCommand[] { this }, SingleCommandPayloadCreator.Instance, behavior, ioBehavior, cancellationToken).ConfigureAwait(false);
271271
}
272272

273273
public MySqlCommand Clone() => new MySqlCommand(this);

0 commit comments

Comments
 (0)