Revalidate missing stored procedures in DeriveParameters. Fixes #730

Author: bgrainger

src/MySqlConnector/Core/CommandExecutor.cs

@@ -36,7 +36,7 @@ public static async Task<DbDataReader> ExecuteReaderAsync(IReadOnlyList<IMySqlCo
 					var commandText = command2.CommandText!;
 					if (!cachedProcedures.ContainsKey(commandText))
 					{
-						cachedProcedures.Add(commandText, await connection.GetCachedProcedure(ioBehavior, commandText, cancellationToken).ConfigureAwait(false));
+						cachedProcedures.Add(commandText, await connection.GetCachedProcedure(commandText, revalidateMissing: false, ioBehavior, cancellationToken).ConfigureAwait(false));
 
 						// because the connection was used to execute a MySqlDataReader with the connection's DefaultCommandTimeout,
 						// we need to reapply the command's CommandTimeout (even if some of the time has elapsed)

src/MySqlConnector/MySql.Data.MySqlClient/MySqlCommandBuilder.cs

@@ -32,7 +32,7 @@ private static async Task DeriveParametersAsync(IOBehavior ioBehavior, MySqlComm
 			if (command.Connection.Session.ServerVersion.Version < ServerVersions.SupportsProcedureCache)
 				throw new NotSupportedException("MySQL Server {0} doesn't support INFORMATION_SCHEMA".FormatInvariant(command.Connection.Session.ServerVersion.OriginalString));
 
-			var cachedProcedure = await command.Connection.GetCachedProcedure(ioBehavior, command.CommandText!, cancellationToken).ConfigureAwait(false);
+			var cachedProcedure = await command.Connection.GetCachedProcedure(command.CommandText!, revalidateMissing: true, ioBehavior, cancellationToken).ConfigureAwait(false);
 			if (cachedProcedure is null)
 			{
 				var name = NormalizedSchema.MustNormalize(command.CommandText!, command.Connection.Database);

src/MySqlConnector/MySql.Data.MySqlClient/MySqlConnection.cs

@@ -494,7 +494,7 @@ internal void Cancel(ICancellableCommand command)
 			}
 		}
 
-		internal async Task<CachedProcedure?> GetCachedProcedure(IOBehavior ioBehavior, string name, CancellationToken cancellationToken)
+		internal async Task<CachedProcedure?> GetCachedProcedure(string name, bool revalidateMissing, IOBehavior ioBehavior, CancellationToken cancellationToken)
 		{
 			if (Log.IsDebugEnabled())
 				Log.Debug("Session{0} getting cached procedure Name={1}", m_session!.Id, name);
@@ -519,7 +519,7 @@ internal void Cancel(ICancellableCommand command)
 			bool foundProcedure;
 			lock (cachedProcedures)
 				foundProcedure = cachedProcedures.TryGetValue(normalized.FullyQualified, out cachedProcedure);
-			if (!foundProcedure)
+			if (!foundProcedure || (cachedProcedure is null && revalidateMissing))
 			{
 				cachedProcedure = await CachedProcedure.FillAsync(ioBehavior, this, normalized.Schema!, normalized.Component!, cancellationToken).ConfigureAwait(false);
 				if (Log.IsWarnEnabled())

tests/SideBySide/StoredProcedureTests.cs

@@ -545,6 +545,38 @@ public void DeriveParametersDoesNotExist()
 			Assert.Throws<MySqlException>(() => MySqlCommandBuilder.DeriveParameters(cmd));
 		}
 
+		[Fact]
+		public void DeriveParametersDoesNotExistThenIsCreated()
+		{
+			using (var cmd = new MySqlCommand("drop procedure if exists xx_does_not_exist_2;", m_database.Connection))
+				cmd.ExecuteNonQuery();
+
+			using (var cmd = new MySqlCommand("xx_does_not_exist_2", m_database.Connection))
+			{
+				cmd.CommandType = CommandType.StoredProcedure;
+				Assert.Throws<MySqlException>(() => MySqlCommandBuilder.DeriveParameters(cmd));
+			}
+
+			using (var cmd = new MySqlCommand(@"create procedure xx_does_not_exist_2(
+					IN param1 INT,
+					OUT param2 VARCHAR(100))
+				BEGIN
+					SELECT 'test' INTO param2;
+				END", m_database.Connection))
+			{
+				cmd.ExecuteNonQuery();
+			}
+
+			using (var cmd = new MySqlCommand("xx_does_not_exist_2", m_database.Connection))
+			{
+				cmd.CommandType = CommandType.StoredProcedure;
+				MySqlCommandBuilder.DeriveParameters(cmd);
+				Assert.Collection(cmd.Parameters.Cast<MySqlParameter>(),
+					AssertParameter("@param1", ParameterDirection.Input, MySqlDbType.Int32),
+					AssertParameter("@param2", ParameterDirection.Output, MySqlDbType.VarChar));
+			}
+		}
+
 		[SkippableFact(ServerFeatures.Json, Baseline = "https://bugs.mysql.com/bug.php?id=89335")]
 		public void DeriveParametersSetJson()
 		{