Prepared: Prevent mem allocs during cleanup #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a prepared statement is collected during a GC run and the d'tor is called, it causes another allocation through either: - allocation of the packet array - allocation of an exception when trying to write to a closed connection In both cases, the GC freaks out and throws an InvalidMemoryOperation. This commit fixes the two allocation cases I found. There may be more.
|
@Abscissa it would be cool if you could release this as a new version, too. I am hitting that bug very easy in my project |
|
Ping? |
|
Sorry, been busy. PR looks good, merging. New release is being held up by one thing: recent #132/#135 discussion revealed some build failures on certain compiler versions which I need to take care of (mainly just working around https://issues.dlang.org/show_bug.cgi?id=17482 IIRC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a prepared statement is collected during a GC run and the d'tor is
called, it causes another allocation through either:
In both cases, the GC freaks out and throws an InvalidMemoryOperation.
This commit fixes the two allocation cases I found. There may be more.
Here is an example backtrace of this:
https://gist.github.com/Marenz/b3293f3a6daa9706a5552a4e68b1cec5