Skip to content

Add DTS issue workaround and prepare release #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 17, 2019
Merged

Conversation

mrmckeb
Copy link
Owner

@mrmckeb mrmckeb commented Sep 15, 2019

Closes #41 (temporary fix until we can investigate further).

@mrmckeb mrmckeb added this to the v1.3.0 milestone Sep 15, 2019
@mrmckeb mrmckeb requested a review from lianapache September 15, 2019 17:11
@mrmckeb mrmckeb self-assigned this Sep 15, 2019
@mrmckeb mrmckeb changed the title Feature/ready 1.3.0 Add temporary DTS issue and prepare release Sep 15, 2019
@mrmckeb mrmckeb changed the title Add temporary DTS issue and prepare release Add DTS issue workaround and prepare release Sep 15, 2019
Copy link
Collaborator

@lianapache lianapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have one question. Otherwise looks good 🙂

@mrmckeb mrmckeb merged commit 8698439 into develop Sep 17, 2019
@mrmckeb mrmckeb deleted the feature/ready-1.3.0 branch September 17, 2019 12:19
@dko-slapdash
Copy link

Love this, thanks!
I want to start using, but it's not yet published to npm AFAIK.

@mrmckeb
Copy link
Owner Author

mrmckeb commented Sep 18, 2019

@dko-slapdash This is now out, let me know how you go! Thanks ;)

@dko-slapdash
Copy link

I've been using it for 2-3 weeks, it works, the problem disappeared. There is another problem, the new classes added to *.module.css file do not get recognized in the referring file immediately, there is a delay of 5-10 (sometimes infinity) seconds, but I believe it's not necessarily related to the above issue.

Thanks for applying the "export default classes" hack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes tsserver crashes, and typescript-plugin-css-modules stops understanding the classes
3 participants