-
Notifications
You must be signed in to change notification settings - Fork 74
Add TypeScript server logs for exceptions #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dagda1, this is great - thanks. There are a few things I'd change, but I don't have a lot of time and as they're stylistic things, I think it's better to merge this and release, and I can just make the changes at a later date. I'll get @lianapache to review too, and then we can merge and release. |
@mrmckeb I'm always interested in feedback if you have time, even if it is stylistic. Thanks for the shout out about the email, I recently deleted an old google account that was in my git.config. |
@mrmckeb is the PR good to go? |
Yes, thanks! I plan to merge and release tomorrow. |
I know you asked for feedback too - it was stylistic in the sense that we try to keep a functional-approach in this package, but that was all. Thanks for the contribution! |
You can install this with the beta tag ( |
@mrmckeb no apologies necessary, thank you for creating this as it is something I have been wanting to do |
This is now in 1.3.1 (out of beta). Thanks again! |
Resolves #36.
The logger gets passed in with the
info
object in the language servicecreate
function which is a bit annoying so you need to pass it to any function needing it.I've wrapped it in a very simple
LanguageServiceLogger
.I've also maybe controversially changed
cssSnapshots.ts
from functions into a class with the only reason being, that I don't have to pass theLogger
to any function that requires it. Could change it back.