Support sass partials imports and css imports in sass files #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @coreymux, and so sorry that I missed this. I'll release shortly. |
|
This has been released, thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Love this plugin so far, but ran into a couple issues trying to add it to my project. This might have only changed due to the sass importer that was added with v3, but I wasn't able to import sass partials or css files. This PR adds support for those, as well as some test coverage for the sass importer.
The issue with sass partials being that sass will allow you import a partial, without including an underscore in the name. The sass importer as is would not resolve those files.
Sass also supports the importing of css files, so I included that case in the sass importer.