Skip to content

Support sass partials imports and css imports in sass files #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2021

Conversation

coreymux
Copy link
Contributor

Hello!

Love this plugin so far, but ran into a couple issues trying to add it to my project. This might have only changed due to the sass importer that was added with v3, but I wasn't able to import sass partials or css files. This PR adds support for those, as well as some test coverage for the sass importer.

The issue with sass partials being that sass will allow you import a partial, without including an underscore in the name. The sass importer as is would not resolve those files.

// can resolve './_colors.scss'
@import 'colors'

Sass also supports the importing of css files, so I included that case in the sass importer.

@mrmckeb
Copy link
Owner

mrmckeb commented Jan 24, 2021

Thanks @coreymux, and so sorry that I missed this. I'll release shortly.

@mrmckeb mrmckeb merged commit 2015f7c into mrmckeb:main Jan 24, 2021
@mrmckeb
Copy link
Owner

mrmckeb commented Jan 24, 2021

This has been released, thanks for your work on this!
https://github.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants