feat: sass support for tsconfig path aliases #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WOOLAN
force-pushed
the
feature/sass-tsconfig-paths
branch
from
9df507f to
51ed23e
Compare
mrmckeb
approved these changes
Nov 2, 2020
|
Sorry for the delay @WOOLAN, this looks great - I'll release it shortly! |
|
Thanks, no worries. I read that baseUrl will no longer be required in TypeScript 4.1 and am therefore taking another look at this. Currently my fix requires baseUrl to be set in compilerOptions. I might also have found a way for TS itself to resolve the paths which would mean that we could drop the dependency on tsconfig-paths. Should hopefully make this plugin more future proof against TS updates to baseUrl/paths. My hope is to get it done in the next week or two. I'll submit another PR when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98
Tried to find a way to use TypeScript to resolve the paths, but I could not. Did not want to implement the logic myself, hence a new dependency tsconfig-paths. Feedback welcome.