Skip to content

Fix the last push date variable name #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix the last push date variable name #398

merged 1 commit into from
Feb 3, 2020

Conversation

marco-c
Copy link
Collaborator

@marco-c marco-c commented Feb 3, 2020

Fixes #394

We were setting lastPushDate in zero_coverage_report.js, but then using last_push_date in base.html.

@marco-c marco-c requested a review from La0 February 3, 2020 17:34
La0
La0 approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@La0 La0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on the artifact build 👍

@La0 La0 merged commit efb37af into mozilla:master Feb 3, 2020
@marco-c marco-c deleted the fix_last_push_date branch February 3, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@La0 La0 La0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last push date is not shown
2 participants
@marco-c @La0