Skip to content

PYTHON-3110 [v4.0] Remove use of example.com in CSFLE tests #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

blink1073
Copy link
Member

No description provided.

@ShaneHarvey
Copy link
Member

ShaneHarvey commented Feb 8, 2022

Please schedule the encryption tests for python 3 and 2.7 to make sure those pass. Also I think the link in your commit message is off. Please revert and use git cherry-pick -x 561ee7cf77fcbdefb9e2f46691f2b2ba4c65198b. The -x flag adds a message indicating it's a backport with the original commit's sha which is helpful for future maintainers.

@blink1073
Copy link
Member Author

I fixed the commit and scheduled an encryption run for Python 3.9, but we don't support Python 2.7 on 4.0.x. 😄

@blink1073 blink1073 requested a review from ShaneHarvey February 8, 2022 14:41
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit 146d16b into mongodb:v4.0 Feb 8, 2022
@blink1073 blink1073 deleted the PYTHON-3110-40 branch February 8, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants