PYTHON-3046 Document support for backslashreplace and surrogateescape #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Jan 21, 2022
| @@ -233,7 +233,8 @@ class CodecOptions(_options_base): | |||
| - `unicode_decode_error_handler`: The error handler to apply when | |||
| a Unicode-related error occurs during BSON decoding that would | |||
| otherwise raise :exc:`UnicodeDecodeError`. Valid options include | |||
| 'strict', 'replace', and 'ignore'. Defaults to 'strict'. | |||
| 'strict', 'replace', 'backslashreplace', 'surrogateescape', and | |||
| 'ignore'. Defaults to 'strict'. | |||
There was a problem hiding this comment.
I decided not to link to https://docs.python.org/3/library/codecs.html#error-handlers here because not all of Python's builtin handlers work with bson decoding. For example xmlcharrefreplace, namereplace, and surrogatepass do not work.
There was a problem hiding this comment.
Interesting. Makes sense.
behackett
approved these changes
Jan 21, 2022
juliusgeo
approved these changes
Jan 21, 2022
| @@ -233,7 +233,8 @@ class CodecOptions(_options_base): | |||
| - `unicode_decode_error_handler`: The error handler to apply when | |||
| a Unicode-related error occurs during BSON decoding that would | |||
| otherwise raise :exc:`UnicodeDecodeError`. Valid options include | |||
| 'strict', 'replace', and 'ignore'. Defaults to 'strict'. | |||
| 'strict', 'replace', 'backslashreplace', 'surrogateescape', and | |||
| 'ignore'. Defaults to 'strict'. | |||
There was a problem hiding this comment.
Interesting. Makes sense.
blink1073
approved these changes
Jan 21, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.