PYTHON-3026 Fix Windows Python 3.6 tests #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Dec 8, 2021
| @@ -28,12 +28,8 @@ createvirtualenv () { | |||
| . $VENVPATH/bin/activate | |||
| fi | |||
|
|
|||
| PYVER=$(${PYTHON} -c "import sys; sys.stdout.write('.'.join(str(val) for val in sys.version_info[:2]))") | |||
| # pip fails to upgrade in a Python 3.6 venv on Windows. | |||
There was a problem hiding this comment.
This failure no longer happens so when can always upgrade pip now. Upgrading pip resolves the test failures.
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Dec 8, 2021
(cherry picked from commit 1d7b9a8)
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are passing here: https://evergreen.mongodb.com/version/61afbeac1e2d1765ffcf91e9