PYTHON-1864 PYTHON-2931 Spec complaint $readPreference #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop sending $readPreference to standalone servers. Stop sending $readPreference primary because it's the server default.
ShaneHarvey
force-pushed
the
PYTHON-1864
branch
from
0b859d4 to
e56acba
Compare
|
Update to fix the merge conflicts. @juliusgeo please take a look. |
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
Stop sending $readPreference to standalone servers. Stop sending $readPreference primary because it's the server default. Remove outdated secondary_ok flag.
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Stop sending $readPreference to standalone servers. Stop sending $readPreference primary because it's the server default. Remove outdated secondary_ok flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes how pymongo sends $readPreference to the server via OP_MSG:
This change also removes the
secondary_okvariable which is no longer needed. Instead of tracking the "secondary ok" boolean we replace the input read preference with the effective read preference (primary, primaryPreferred, or the original read preference).This change depends on #774 so please review that one first.