PYTHON-3017 Properly check for closed KMS connections #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
commented
Nov 16, 2021
| @@ -129,6 +129,8 @@ def kms_request(self, kms_context): | |||
| conn.sendall(message) | |||
| while kms_context.bytes_needed > 0: | |||
| data = conn.recv(kms_context.bytes_needed) | |||
| if not data: | |||
| raise OSError('KMS connection closed') | |||
There was a problem hiding this comment.
What was happening here is that the connection was closed, recv returns b'' and then we get stuck in an infinite loop.
behackett
approved these changes
Nov 16, 2021
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Nov 16, 2021
(cherry picked from commit 99aab1b)
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.