PYTHON-1690: Fix error message when insert_many is given a single RawBSONDocument instead of a list

[guanlinzhou]

Changed type checking from abc.Iterable to abc.Sequence in order to better match 'list-like' types

TypeError                                 
Traceback (most recent call last)
<ipython-input-6-9084eaf77999> in <module>
----> 1 client.test.test.insert_many(RawBSONDocument(bson.BSON.encode({'_id':2})))

~/mongo-python-driver/pymongo/collection.py in insert_many(self, documents, ordered, bypass_document_validation, session)
    688         """
    689         if not isinstance(documents, abc.Sequence) or not documents:
--> 690             raise TypeError("documents must be a non-empty list")
    691         inserted_ids = []
    692         def gen():

TypeError: documents must be a non-empty list

[guanlinzhou]

@prashantmital @ShaneHarvey thoughts on whether this requires a testing change? I was looking for tests for invalid input types and couldn't find any existing ones

[ShaneHarvey]

Yeah it would be great to add a test in test_collection.py which uses with self.assertRaisesRegex(... on various invalid types.

[guanlinzhou]

Yeah it would be great to add a test in test_collection.py which uses with self.assertRaisesRegex(... on various invalid types.

added tests in the most recent commit

[prashantmital]

LGTM 🥳

Note that normally if you would have backported this commit to a branch that tested against Python 2.7, your tests would have failed because you are using assertRaisesRegex where Py 2 called that same method assertRaisesRegexp. Fortunately, our test setup code has a nifty tweak in place to prevent this from becoming a problem - see

mongo-python-driver/test/__init__.py

Line 822 in c40a455

# Use assertRaisesRegex if available, otherwise use Python 2.7's

[ShaneHarvey]

Please run the tests before pushing a backport to v3.12. I think the abc.Mapping usage may be different in that branch.