PYTHON-4580 Add key_expiration_ms option for DEK cache lifetime #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review but mongodb/libmongocrypt#984 still needs to be merged first. |
sleepyStick
reviewed
Mar 10, 2025
pyproject.toml
Outdated
| @@ -59,7 +59,7 @@ mockupdb = [ | |||
| "mockupdb@git+https://github.com/mongodb-labs/mongo-mockup-db@master" | |||
| ] | |||
| pymongocrypt_source = [ | |||
| "pymongocrypt@git+https://github.com/mongodb/libmongocrypt@master#subdirectory=bindings/python" | |||
| "pymongocrypt@git+https://github.com/ShaneHarvey/libmongocrypt@PYTHON-5191#subdirectory=bindings/python" | |||
There was a problem hiding this comment.
was this an intentional change?
There was a problem hiding this comment.
Yes, I needed this to test the new changes. Now that mongodb/libmongocrypt#984 is merged I was able to revert this.
This reverts commit db5cee8.
sleepyStick
previously approved these changes
Mar 10, 2025
sleepyStick
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PYTHON-4580 Add key_expiration_ms option for DEK cache lifetime
Depends on mongodb/libmongocrypt#984