PYTHON-4455 Improve import time on Windows #1645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyclements
previously approved these changes
May 28, 2024
ShaneHarvey
previously approved these changes
May 28, 2024
|
Name: "Windows 10" -> "Windows" |
ShaneHarvey
reviewed
May 28, 2024
pymongo/pool.py
Outdated
| "name": "Windows", | ||
| # Avoid using platform calls, see PYTHON-4455. | ||
| "architecture": os.environ.get("PROCESSOR_ARCHITECTURE") or platform.machine(), | ||
| # Windows patch level (e.g. 10-0-17763). |
There was a problem hiding this comment.
is 10-0-17763 accurate? I would expect something like 10.0.17763-XXX
There was a problem hiding this comment.
I need to update the comment, I just pushed a change to make it format the same as the old way.
ShaneHarvey
approved these changes
May 29, 2024
blink1073
added a commit
to blink1073/mongo-python-driver
that referenced
this pull request
May 30, 2024
(cherry picked from commit 1d6cf42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.