PYTHON-2965 Migrate to a PEP517 compliant build system #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Jun 21, 2023
| @@ -4,10 +4,6 @@ | |||
| import sys | |||
| import warnings | |||
|
|
|||
| if sys.version_info[:3] < (3, 7): | |||
| raise RuntimeError("Python version >= 3.7 required.") | |||
There was a problem hiding this comment.
Do we still need this as long as setup.py exists?
There was a problem hiding this comment.
No, setuptools will use the python_requires config from pyproject.toml.
ShaneHarvey
reviewed
Jun 21, 2023
setup.py
Outdated
| readme_content = "" | ||
| finally: | ||
| f.close() | ||
|
|
||
| # PYTHON-654 - Clang doesn't support -mno-fused-madd but the pythons Apple |
There was a problem hiding this comment.
How does the new build process handle this "-mno-fused-madd" issue? Or is it no longer a concern.
There was a problem hiding this comment.
Actually, we don't need to use the stdlib distutils at all, and the distutils that ships with setuptools does not add this flag. I cleaned up this block.
ShaneHarvey
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.