-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-2818 Add native support for AWS IAM Roles for service accounts, EKS in particular #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…, EKS in particular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's wait for DRIVERS-1746 before merging.
pymongo/auth_aws.py
Outdated
@@ -78,6 +78,7 @@ def _authenticate_aws(credentials, sock_info): | |||
credentials.mechanism_properties.aws_session_token, | |||
) | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this whitespace change intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Depends on mongodb-labs/drivers-evergreen-tools#223