Skip to content

Replace Stack with ArrayDeque. #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Replace Stack with ArrayDeque. #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f5732d
Replace Stack with ArrayDeque.
vbabanin Apr 14, 2025
7883749
Correct tests.
vbabanin Apr 16, 2025
160b168
Remove CommandMessage optimization.
vbabanin Apr 16, 2025
68d1e72
Rename field names to better alight with implementation logic.
vbabanin Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bson/src/main/org/bson/AbstractBsonWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@
import org.bson.types.ObjectId;

import java.io.Closeable;
import java.util.ArrayDeque;
import java.util.Arrays;
import java.util.Deque;
import java.util.List;
import java.util.Map;
import java.util.Stack;

import static java.lang.String.format;
import static org.bson.assertions.Assertions.notNull;
Expand All @@ -35,7 +36,7 @@
*/
public abstract class AbstractBsonWriter implements BsonWriter, Closeable {
private final BsonWriterSettings settings;
private final Stack<FieldNameValidator> fieldNameValidatorStack = new Stack<>();
private final Deque<FieldNameValidator> fieldNameValidatorStack = new ArrayDeque<>();
private State state;
private Context context;
private int serializationDepth;
Expand Down
5 changes: 3 additions & 2 deletions bson/src/main/org/bson/BsonBinaryWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@
import org.bson.types.Decimal128;
import org.bson.types.ObjectId;

import java.util.ArrayDeque;
import java.util.Deque;
import java.util.List;
import java.util.Stack;

import static java.lang.Math.max;
import static java.lang.String.format;
Expand All @@ -37,7 +38,7 @@ public class BsonBinaryWriter extends AbstractBsonWriter {
private final BsonBinaryWriterSettings binaryWriterSettings;

private final BsonOutput bsonOutput;
private final Stack<Integer> maxDocumentSizeStack = new Stack<>();
private final Deque<Integer> maxDocumentSizeStack = new ArrayDeque<>();
private static final int ARRAY_INDEXES_CACHE_SIZE = 1000;
private static final byte[] ARRAY_INDEXES_BUFFER;
private static final int[] ARRAY_INDEXES_OFFSETS;
Expand Down