Optimize BsonArray Index encoding #1673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-5836
JAVA-5836
vbabanin
changed the title
|
As @ShaneHarvey noted in the previous PR (#1664 (comment)), Python caches 1000 consecutive array indexes. To align with that behavior across drivers, I’ve adjusted the cache size to 1000 in the Java driver. |
vbabanin
commented
Apr 3, 2025
| private static final int ARRAY_INDEXES_CACHE_SIZE = 256; | ||
| private static final String[] ARRAY_INDEXES_CACHE = new String[ARRAY_INDEXES_CACHE_SIZE]; | ||
| private static final int ARRAY_INDEXES_CACHE_SIZE = 1000; | ||
| private static final byte[] ARRAY_INDEXES_BUFFER; |
There was a problem hiding this comment.
In prior benchmarks, the reference-chasing layout (i.e., byte[][]) showed ~25% lower throughput compared to a flat byte[] layout, primarily due to fragmented sequential locality and indirect memory access.
rozza
approved these changes
Apr 3, 2025
| @@ -66,7 +66,7 @@ public void shouldThrowWhenMaxDocumentSizeIsExceeded() { | |||
| writer.writeEndDocument(); | |||
| fail(); | |||
| } catch (BsonMaximumSizeExceededException e) { | |||
| assertEquals("Document size of 1037 is larger than maximum of 1024.", e.getMessage()); | |||
| assertEquals("Document size of 12917 is larger than maximum of 12904.", e.getMessage()); | |||
There was a problem hiding this comment.
Did this get missed last time? Yes it did - thanks for fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of caching precomputed
Stringvalues, we now cache their corresponding byte[] representations. This avoids repeated ASCII string decoding.The single contiguous buffer approach provides better cache locality in loops, reduced memory overhead and better performance.
The array index caching implementation consumes approximately
12 KB of memory in total:Array object headers: ~48 bytesBsonArrayCodecBenchmark results:
JAVA-5836