-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4385: Consider adding Directory.Build.props. #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f267189
CSHARP-4385: Consider adding Directory.Build.props.
DmitryLukyanov a14c635
Code review.
DmitryLukyanov ad35381
Code review.
DmitryLukyanov 7f186ee
Test fix.
DmitryLukyanov 121025c
Formatting.
DmitryLukyanov cb68c3e
Code review.
DmitryLukyanov edc9308
Remove commong build.props in tests.
DmitryLukyanov 809c3eb
Code review.
DmitryLukyanov 6e8658c
Update contributors list.
DmitryLukyanov ef87dd1
Merge branch 'master' into csharp4385
DmitryLukyanov 8063eb9
Fix reference issue.
DmitryLukyanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,7 @@ Please see our [guidelines](CONTRIBUTING.md) for contributing to the driver. | |
| * Bar Arnon https://github.com/I3arnon | ||
| * Wan Bachtiar https://github.com/sindbach | ||
| * Mark Benvenuto https://github.com/markbenvenuto | ||
| * Brian Buvinghausen https://github.com/buvinghausen | ||
| * Bit Diffusion Limited [email protected] | ||
| * Jimmy Bogard https://github.com/jbogard | ||
| * Ross Buggins https://github.com/rbugginsvia | ||
|
|
@@ -105,12 +106,15 @@ Please see our [guidelines](CONTRIBUTING.md) for contributing to the driver. | |
| * Ken Egozi [email protected] | ||
| * Alexander Endris https://github.com/AlexEndris | ||
| * Daniel Goldman [email protected] | ||
| * David Golub https://github.com/dgolub | ||
| * Simon Green [email protected] | ||
| * Bouke Haarsma https://github.com/Bouke | ||
| * James Hadwen [email protected] | ||
| * Nuri Halperin https://github.com/nurih | ||
| * Daniel Hegener [email protected] | ||
| * Nikola Irinchev https://github.com/nirinchev | ||
| * Jacob Jewell [email protected] | ||
| * Vincent Kam https://github.com/vincentkam | ||
| * Danny Kendrick https://github.com/dkendrick | ||
| * Ruslan Khasanbaev https://github.com/flaksirus | ||
| * Konstantin Khitrykh https://github.com/KonH | ||
|
|
@@ -123,6 +127,7 @@ Please see our [guidelines](CONTRIBUTING.md) for contributing to the driver. | |
| * Maksim Krautsou https://github.com/MaKCbIMKo | ||
| * Richard Kreuter [email protected] | ||
| * Daniel Lee https://github.com/dlee148 | ||
| * Ming Yau Lee https://github.com/mingyaulee | ||
| * Kevin Lewis [email protected] | ||
| * Dow Liu [email protected] | ||
| * Chuck Lu https://github.com/chucklu | ||
|
|
@@ -133,6 +138,7 @@ Please see our [guidelines](CONTRIBUTING.md) for contributing to the driver. | |
| * Alexander Nagy [email protected] | ||
| * Sridhar Nanjundeswaran https://github.com/sridharn | ||
| * Nathan https://github.com/terakilobyte | ||
| * Adelin Owona https://github.com/adelinowona | ||
| * Rachelle Palmer https://github.com/techbelle | ||
| * Rich Quackenbush [email protected] | ||
| * Carl Reinke https://github.com/mindless2112 | ||
|
|
@@ -142,24 +148,19 @@ Please see our [guidelines](CONTRIBUTING.md) for contributing to the driver. | |
| * Ed Rooth [email protected] | ||
| * Katie Sadoff https://github.com/ksadoff | ||
| * Sam558 https://github.com/Sam558 | ||
| * Vladimir Setyaev [email protected] | ||
| * Sergey Shushlyapin https://github.com/sergeyshushlyapin | ||
| * Alexey Skalozub [email protected] | ||
| * Kevin Smith https://github.com/kevbite | ||
| * Pete Smith [email protected] | ||
| * Matteo Spreafico https://github.com/MatteoSp | ||
| * staywellandy https://github.com/staywellandy | ||
| * Vyacheslav Stroy https://github.com/kreig | ||
| * Jake Sta. Teresa https://github.com/JakeStaTeresa | ||
| * Testo [email protected] | ||
| * TimTim https://github.com/wegylexy | ||
| * Craig Wilson https://github.com/craiggwilson | ||
| * Zhmayev Yaroslav https://github.com/salaros | ||
| * Aristarkh Zagorodnikov https://github.com/onyxmaster | ||
| * Vincent Kam https://github.com/vincentkam | ||
| * Craig Wilson https://github.com/craiggwilson | ||
| * Ming Yau Lee https://github.com/mingyaulee | ||
| * Daniel Hegener [email protected] | ||
| * Vladimir Setyaev [email protected] | ||
| * Matteo Spreafico https://github.com/MatteoSp | ||
| * Adelin Owona https://github.com/adelinowona | ||
| * David Golub https://github.com/dgolub | ||
|
|
||
| If you have contributed and we have neglected to add you to this list please contact one of the maintainers to be added to the list (with apologies). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| <Project> | ||
BorisDog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <PropertyGroup> | ||
| <IsWindows Condition="$([MSBuild]::IsOSPlatform('Windows'))">true</IsWindows> | ||
| </PropertyGroup> | ||
BorisDog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(IsWindows)'=='true'">$(TargetFrameworks);net472</TargetFrameworks> | ||
| <LangVersion>10.0</LangVersion> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <CodeAnalysisRuleSet>..\..\MongoDB.ruleset</CodeAnalysisRuleSet> | ||
BorisDog marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <Company>MongoDB Inc.</Company> | ||
| <Copyright>Copyright © 2010-present MongoDB Inc.</Copyright> | ||
| <Authors>MongoDB Inc.</Authors> | ||
| <PackageIcon>packageIcon.png</PackageIcon> | ||
| <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance> | ||
| <PackageProjectUrl>https://www.mongodb.com/docs/drivers/csharp/</PackageProjectUrl> | ||
| <PackageTags>mongodb;mongo;nosql</PackageTags> | ||
| <PackageLicenseFile>License.txt</PackageLicenseFile> | ||
| <PackageLanguage>en-US</PackageLanguage> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Version)'==''"> | ||
| <Version>0.0.0-local</Version> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.2" PrivateAssets="All" /> | ||
| <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" /> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="..\..\License.txt" Pack="true" PackagePath="$(PackageLicenseFile)" /> | ||
| <None Include="..\..\packageIcon.png" Pack="true" PackagePath="" /> | ||
| </ItemGroup> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,68 +1,23 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <IsWindows Condition="$([MSBuild]::IsOSPlatform('Windows'))">true</IsWindows> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;netstandard2.1;net472</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(IsWindows)'!='true'">netstandard2.0;netstandard2.1</TargetFrameworks> | ||
| <LangVersion>10.0</LangVersion> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <WarningsAsErrors /> | ||
| <CodeAnalysisRuleSet>..\..\MongoDBLegacy.ruleset</CodeAnalysisRuleSet> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <AssemblyTitle>MongoDB.Bson</AssemblyTitle> | ||
| <Product>MongoDB.Bson</Product> | ||
| <Company>MongoDB Inc.</Company> | ||
| <Copyright>Copyright © 2010-present MongoDB Inc.</Copyright> | ||
| <Description>Official MongoDB supported BSON library. See https://www.mongodb.com/docs/drivers/csharp/ for more details.</Description> | ||
| <Authors>MongoDB Inc.</Authors> | ||
| <PackageIcon>packageIcon.png</PackageIcon> | ||
| <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance> | ||
| <PackageDescription>MongoDB's Official Bson Library.</PackageDescription> | ||
| <PackageProjectUrl>https://www.mongodb.com/docs/drivers/csharp/</PackageProjectUrl> | ||
| <PackageLicenseFile>License.txt</PackageLicenseFile> | ||
| <PackageTags>mongodb;mongo;nosql;bson</PackageTags> | ||
| <PackageLanguage>en-US</PackageLanguage> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Version)'==''"> | ||
| <Version>0.0.0-local</Version> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <PackageTags>$(PackageTags);bson</PackageTags> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.2" PrivateAssets="All" /> | ||
| <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Include="..\MongoDB.Shared\Hasher.cs" Link="Hasher.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="..\..\License.txt" Pack="true" PackagePath="$(PackageLicenseFile)" /> | ||
| <None Include="..\..\packageIcon.png" Pack="true" PackagePath="" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,69 +1,21 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <IsWindows Condition="$([MSBuild]::IsOSPlatform('Windows'))">true</IsWindows> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>netstandard2.0;netstandard2.1;net472</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(IsWindows)'!='true'">netstandard2.0;netstandard2.1</TargetFrameworks> | ||
| <LangVersion>10.0</LangVersion> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <WarningsAsErrors /> | ||
| <CodeAnalysisRuleSet>..\..\MongoDB.ruleset</CodeAnalysisRuleSet> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <AssemblyTitle>MongoDB.Driver.GridFS</AssemblyTitle> | ||
| <Product>MongoDB.Driver.GridFS</Product> | ||
| <Company>MongoDB Inc.</Company> | ||
| <Copyright>Copyright © 2010-present MongoDB Inc.</Copyright> | ||
| <Description>Official MongoDB supported driver for MongoDB GridFS implementation. See https://www.mongodb.com/docs/drivers/csharp/ for more details.</Description> | ||
| <Authors>MongoDB Inc.</Authors> | ||
| <PackageIcon>packageIcon.png</PackageIcon> | ||
| <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance> | ||
| <PackageDescription>GridFS Component of the Official MongoDB .NET Driver.</PackageDescription> | ||
| <PackageProjectUrl>https://www.mongodb.com/docs/drivers/csharp/</PackageProjectUrl> | ||
| <PackageLicenseFile>License.txt</PackageLicenseFile> | ||
| <PackageTags>mongodb;mongo;nosql;gridfs</PackageTags> | ||
| <PackageLanguage>en-US</PackageLanguage> | ||
| <IncludeSymbols>true</IncludeSymbols> | ||
| <SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
| <PublishRepositoryUrl>true</PublishRepositoryUrl> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(Version)'==''"> | ||
| <Version>0.0.0-local</Version> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <DefineConstants>TRACE</DefineConstants> | ||
| <PackageTags>$(PackageTags);gridfs</PackageTags> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="All" Version="1.0.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.6.2" PrivateAssets="All" /> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1"> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
| </PackageReference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\MongoDB.Bson\MongoDB.Bson.csproj" /> | ||
| <ProjectReference Include="..\MongoDB.Driver\MongoDB.Driver.csproj" /> | ||
| <ProjectReference Include="..\MongoDB.Driver.Core\MongoDB.Driver.Core.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Include="..\..\License.txt" Pack="true" PackagePath="$(PackageLicenseFile)" /> | ||
| <None Include="..\..\packageIcon.png" Pack="true" PackagePath=""/> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's possible to add this file into solution directory, but given that configuration makes sense only for src folder, probably better to leave it where it's currently placed