CDRIVER-4269 support PKCS#8 keys with Secure Channel #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To indicate only RSA key data is referred to.
To remove repeated double-call (once to get length, once to decode).
eramongodb
requested changes
Jun 2, 2025
Co-authored-by: Ezra Chung <[email protected]>
To help with readability (easier to miss missing initialize).
eramongodb
approved these changes
Jun 3, 2025
mdb-ad
approved these changes
Jun 4, 2025
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
Jun 4, 2025
Co-authored-by: Ezra Chung <[email protected]>
kevinAlbs
added a commit
to kevinAlbs/mongo-c-driver
that referenced
this pull request
Jun 4, 2025
Co-authored-by: Ezra Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support PKCS#8 RSA keys with Windows Secure Channel
Patch build: https://spruce.mongodb.com/version/683853839983780007e8a268
Background
Intended to ease using MONGODB-X509 with Atlas. Atlas creates client certificates in PKCS#8 with RSA keys. Prior to these changes, attempting to load a PKCS#8 key with the C driver built with Secure Channel results in this error:
This PR only adds support for unencrypted RSA keys. This is similar to the server limitation loading from file. I expect future support of non-RSA keys will require a more substantial change to switch to CNG (see CDRIVER-4530). This PR is intended to be backported to enable X509 auth to Atlas without the needed workaround described in CDRIVER-4269 (convert to PKCS#1).
The test client certificate, pkcs8-unencrypted.pem is copied from drivers-evergreen-tools.