Skip to content

char and ascii_char contracts #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

carolynzech
Copy link

Add contracts for char_try_from_u32, from_u32_unchecked, from_u8_unchecked, from_u8, and as_ascii.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@carolynzech carolynzech requested a review from a team as a code owner August 1, 2024 15:56
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Some of the ensures clauses need strengthening.

@carolynzech carolynzech requested a review from zhassan-aws August 1, 2024 19:08
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carolynzech carolynzech merged commit 0be79d6 into model-checking:main Aug 1, 2024
6 checks passed
@carolynzech carolynzech deleted the char-contracts branch August 1, 2024 20:29
szlee118 pushed a commit to stogaru/verify-rust-std that referenced this pull request Oct 17, 2024
Add contracts for `char_try_from_u32`, `from_u32_unchecked`,
`from_u8_unchecked`, `from_u8`, and `as_ascii`.

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants