forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 48
Parse log file of multi-threaded Kani run (terse output) into JSON #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tautschnig
wants to merge
3
commits into
model-checking:main
Choose a base branch
from
tautschnig:metrics-tooling2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a run of Kani on the standard library with `--verbose` (and, typically, `autoharness`) enabled this produces a machine-processable JSON result via ``` python3 log_parser.py \ --kani-list-file kani-list.json \ --analysis-results-dir std_lib_analysis/results/ \ verification.log -o results.json ``` where each entry in the resulting JSON array is of the form ``` { "thread_id": int, "result": { "harness": string, "is_autoharness": bool, "autoharness_result": string, "with_contract": bool, "crate": string, "function": string, "function_safeness": string, "file_name": string, "n_failed_properties": int, "n_total_properties": int, "result": string, "time": string, "output": array } } ``` With the help of `jq` one can then conveniently compute various metrics, e.g., ``` jq 'map(select(.result.result == "SUCCESSFUL" and .result.is_autoharness == true and .result.crate == "core" and .result.function_safeness == "unsafe" and .result.with_contract == true)) | length' results.json ``` to find the number of successfully-verified contracts of unsafe functions in crate `core` that were verified using automatically generated harnesses.
carolynzech
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Michael! It looks like these results will be very useful. My comments can be summarized as:
- asking for a bit more inline documentation, especially where we're doing some hardcoding to get around edge cases, and
- whether we should try to avoid duplicate dictionary keys
carolynzech
reviewed
Apr 22, 2025
carolynzech
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a run of Kani on the standard library with
--jobs=<N> --output-format=terse
(and, typically,autoharness
) enabled this produces a machine-processable JSON result viawhere each entry in the resulting JSON array is of the form
With the help of
jq
one can then conveniently compute various metrics, e.g.,to find the number of successfully-verified contracts of unsafe functions in crate
core
that were verified using automatically generated harnesses.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.