Skip to content

Add review guidelines #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions doc/src/general-rules.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,21 @@ members = [
+ "rahulku"
]
```

Committee members are expected to contribute by reviewing pull requests (all
pull requests review approvals from at least two committee members before they
can be merged).
Reviews of solutions towards challenges should consider at least the following aspects:

1. Does the pull request implement a solution that respects/meets the success
criteria of the challenge?
2. Do the contracts and harnesses incorporate the safety conditions stated in
the documentation (from comments in the code and the
[standard library documentation](https://doc.rust-lang.org/std/index.html))?
Note that we currently focus on safety verification. Pre- and post-conditions
towards functional correctness are acceptable as long as they do not
negatively impact verification of safety, such as over-constraining input
values or causing excessive verification run time.
3. Is the contributed code of adequate quality, idiomatic, and stands a chance
to be accepted into the standard library (to the best of the committee
member's knowledge)?
Loading