Skip to content

Kani Workflow Updates #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

carolynzech
Copy link

@carolynzech carolynzech commented Dec 6, 2024

Update the kani list part of our workflow to:

  • Be its own step of the workflow so it can run in parallel, which is nice because it finishes much faster than the other jobs in the Kani workflow
  • Use the new markdown format. This makes the list much more readable (compare current format to markdown format).

Also remove the Test Kani workflow step, because it's expensive and duplicates verification work.

@carolynzech carolynzech requested a review from a team as a code owner December 6, 2024 17:27
@celinval
Copy link

celinval commented Dec 6, 2024

Since you are changing this file, can you please modify the Test Kani script job to stop verifying all the harnesses. Maybe we can pass --kani-args --only-codegen which will only compile the standard library. Thanks!

@celinval
Copy link

celinval commented Dec 6, 2024

Per offline discussion, let's delete the Test Kani script job instead.

@carolynzech carolynzech changed the title Kani List Workflow Updates Kani Workflow Updates Dec 6, 2024
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@zhassan-aws zhassan-aws enabled auto-merge (squash) December 6, 2024 23:32
Copy link

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Author

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger merge

@zhassan-aws zhassan-aws merged commit 16a155a into model-checking:main Dec 10, 2024
8 checks passed
@carolynzech carolynzech deleted the markdown-list branch December 10, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants