-
Notifications
You must be signed in to change notification settings - Fork 48
Contracts and harnesses for <*mut T>::offset_from #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts and harnesses for <*mut T>::offset_from #168
Conversation
@feliperodri FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice harnesses! I only have some nits.
Minor change Co-authored-by: Carolyn Zech <[email protected]>
Minor change 2 Co-authored-by: Carolyn Zech <[email protected]>
Minor change 3 Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Carolyn Zech <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor suggestions.
minor comment change Co-authored-by: Felipe R. Monteiro <[email protected]>
@MayureshJoshi25 could you resolve the conflicts? |
Co-authored-by: Felipe R. Monteiro <[email protected]>
Co-authored-by: Felipe R. Monteiro <[email protected]>
@MayureshJoshi25 I'm afraid this requires another round of resolving conflicts. |
@MayureshJoshi25 coild you solve the conflicts so we can merge it? |
Head branch was pushed to by a user without write access
@feliperodri resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trigger merge workflow
Towards #76
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.