Skip to content

Contracts and harnesses for <*mut T>::offset_from #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MayureshJoshi25
Copy link

@MayureshJoshi25 MayureshJoshi25 commented Nov 16, 2024

Added contracts for offset_from (mut type):

Accomplished using a macro which generates harnesses.

Verifies: int types, unit, tuples (composite types)

Towards #76

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@MayureshJoshi25 MayureshJoshi25 requested a review from a team as a code owner November 16, 2024 01:15
@stogaru
Copy link

stogaru commented Nov 16, 2024

@feliperodri FYI

Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice harnesses! I only have some nits.

@carolynzech carolynzech self-assigned this Nov 22, 2024
MayureshJoshi25 and others added 5 commits November 23, 2024 19:42
Minor change

Co-authored-by: Carolyn Zech <[email protected]>
Minor change 2

Co-authored-by: Carolyn Zech <[email protected]>
Minor change 3

Co-authored-by: Carolyn Zech <[email protected]>
Copy link

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor suggestions.

MayureshJoshi25 and others added 2 commits November 27, 2024 17:52
minor comment change

Co-authored-by: Felipe R. Monteiro <[email protected]>
@feliperodri
Copy link

@MayureshJoshi25 could you resolve the conflicts?

MayureshJoshi25 and others added 2 commits December 2, 2024 16:05
@tautschnig
Copy link
Member

@MayureshJoshi25 I'm afraid this requires another round of resolving conflicts.

@feliperodri feliperodri enabled auto-merge (squash) December 5, 2024 15:25
@feliperodri
Copy link

@MayureshJoshi25 coild you solve the conflicts so we can merge it?

auto-merge was automatically disabled December 5, 2024 18:53

Head branch was pushed to by a user without write access

@MayureshJoshi25
Copy link
Author

@feliperodri resolved.

@feliperodri feliperodri enabled auto-merge (squash) December 5, 2024 20:19
Copy link

@carolynzech carolynzech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger merge workflow

@feliperodri feliperodri merged commit a52b65a into model-checking:main Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants