Skip to content

Add a new challenge to verify CStr #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

celinval
Copy link

@celinval celinval commented Nov 4, 2024

Proposes a new challenge to verify the safety of CStr implementation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner November 4, 2024 20:12
@celinval celinval added the Challenge Proposal Used to tag a challenge proposal PR / Issue label Nov 4, 2024
Copy link

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@celinval
Copy link
Author

celinval commented Nov 4, 2024

Oh, I forgot to add the trait implementations for this struct. Let me add them in the next revision.

@celinval celinval closed this Nov 4, 2024
@celinval celinval reopened this Nov 4, 2024
also fix warnings in the tool template section
@qinheping qinheping self-requested a review November 6, 2024 18:03
Copy link

@qinheping qinheping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@celinval celinval enabled auto-merge (squash) November 13, 2024 19:03
Copy link
Author

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger review check

@celinval celinval merged commit 90d304b into model-checking:main Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Challenge Proposal Used to tag a challenge proposal PR / Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants