You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#248 creates a pull request to update subtree/library. There are a few issues I discovered while using it:
The last commit it introduces is erroneous; it should not be creating new submodules. (See how it creates a new library/ folder inside the existing library folder). In CI, the Kani workflow tries to initialize these submodules, but the .gitmodules file doesn't mention them, so CI crashes.
The fix for this issue should produce the exact same output as #248 minus this one erroneous commit.
Improvements to the workflow to update the subtree:
- Check for existing PRs before creating new ones
- Update the Kani version automatically
- Remove erroneous additional submodules
- Typo in toolchain file
Resolves#249
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.
---------
Co-authored-by: Carolyn Zech <[email protected]>
Co-authored-by: Michael Tautschnig <[email protected]>
#248 creates a pull request to update
subtree/library
. There are a few issues I discovered while using it:library/
folder inside the existing library folder). In CI, the Kani workflow tries to initialize these submodules, but the.gitmodules
file doesn't mention them, so CI crashes.The fix for this issue should produce the exact same output as #248 minus this one erroneous commit.
verify-rust-std/.github/workflows/update-subtree.yml
Lines 122 to 124 in b764eeb
should instead be:
so that
rust-toolchain.toml
readsnightly-{DATE}
instead of just{DATE}
The text was updated successfully, but these errors were encountered: