Skip to content

fix(deps): update dependencies for correct linting #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2019
Merged

fix(deps): update dependencies for correct linting #2

merged 1 commit into from
Nov 14, 2019

Conversation

skeggse
Copy link

@skeggse skeggse commented Nov 14, 2019 •
edited
Loading

We've got some PRs that pass commitlint-jenkins but fail semantic-commitlint, which blocks deploys. It looks like bumping the version of the @commitlint dependencies fixes things.

Before

[Semantic release]: Call plugin verify-release
[Semantic release]: 😞   Errors found with commit 429c073
[Semantic release]: 💬   fix(deps): [security] update dependencies for correct linting
[Semantic release]: ✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
[Semantic release]: ✖   found 1 problems, 0 warnings
[Semantic release]: EINVALIDCOMMIT The commit message is not formatted correctly

After

No error!

@skeggse skeggse requested a review from a team November 14, 2019 18:16
@ghost ghost requested review from ttacon and removed request for a team November 14, 2019 18:16
@skeggse skeggse requested review from jpdstan and shils November 14, 2019 18:17
@skeggse skeggse merged commit f812f66 into master Nov 14, 2019
@skeggse skeggse deleted the eli/fix-linting branch November 14, 2019 18:22
@mixmax-bot
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shils shils shils approved these changes

@jpdstan jpdstan jpdstan approved these changes

@ttacon ttacon Awaiting requested review from ttacon

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skeggse @mixmax-bot @shils @jpdstan