add default output path

[aster94]

hello, this is a follow up from the pull request #623

i just modified the output path to work as global (i.e. defined once as the "arduino.path")
This way the user would need to choose it only once instead of choosing one for every sketch. This could be overwritten in the per sketch setting (i.e. .vscode/arduino.json)

i made a video to show that it works
https://streamable.com/casvh

[Sneezry]

Hi @aster94 , it seems this pr has code style issue. Please run tslint task to fix the issue.

[aster94]

@Sneezry done
before merging this could you give some suggestion on the desired output of this function?
https://github.com/aster94/vscode-arduino/blob/add-default-output-path/src/arduino/arduinoSettings.ts#L242
i guess that the best would be "" but i would rather to hear your opinion

[Sneezry]

@aster94 null or undefined makes more sense.

[aster94]

set as undefined let's wait for travis CI
Tslint continue to show errors, but this is not due to my code:

[11:00:49] Starting 'tslint'...
/Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts[39, 1]: trailing whitespace
/Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts[160, 1]: trailing whitespace
/Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts[238, 1]: trailing whitespace
/Users/travis/build/Microsoft/vscode-arduino/src/arduino/vscodeSettings.ts[81, 1]: trailing whitespace
[11:01:00] 'tslint' errored after 11 s
[11:01:00] Error in plugin 'gulp-tslint'
Message:
    Failed to lint: /Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts [39, 1]: trailing whitespace, /Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts [160, 1]: trailing whitespace, /Users/travis/build/Microsoft/vscode-arduino/src/arduino/arduinoSettings.ts [238, 1]: trailing whitespace, /Users/travis/build/Microsoft/vscode-arduino/src/arduino/vscodeSettings.ts [81, 1]: trailing whitespace.

as you can see the problems are in vscodeSettings.ts
line 81
and in arduinoSettings.ts
line 39
line 160
line 238
In all this situation I just followed the code style of the project

[czgtest]

@aster94 Can you help to resolve conflicts?

[aster94]

@czgtest are you talking about merge conflicts? I don't see anymore any of them, you probably solved them with the last commit (fe2fc1c)
Anyway I remember that them were in the readMe file

[czgtest]

@aster94 run command "gulp tslint " and "gulp build" to make sure no error display in you local machine , then update latest code to pull request, travis CI will pass.

[aster94]

Unfortunately i have been too busy in these days, i would do it during the holidays

[aster94]

@czgtest the code works, the only problems i see are related to the trailing whitespaces, again
i already explained that it is nor related to my code but to the style i followed
i can remove these whitespaces if you really need to have tslint without errors.
See the changes, test in your machine and decide yourself if you want to merge it or just close

here there is the output of gulp tslint
[21:38:25] Using gulpfile ~/wip/git/vscode-arduino/gulpfile.js
[21:38:25] Starting 'tslint'...

/home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts[39, 1]: trailing whitespace
/home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts[160, 1]: trailing whitespace
/home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts[238, 1]: trailing whitespace

/home/aster/wip/git/vscode-arduino/src/arduino/vscodeSettings.ts[81, 1]: trailing whitespace

[21:38:29] 'tslint' errored after 4.39 s
[21:38:29] Error in plugin 'gulp-tslint'
Message:
Failed to lint: /home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts [39, 1]: trailing whitespace, /home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts [160, 1]: trailing whitespace, /home/aster/wip/git/vscode-arduino/src/arduino/arduinoSettings.ts [238, 1]: trailing whitespace, /home/aster/wip/git/vscode-arduino/src/arduino/vscodeSettings.ts [81, 1]: trailing whitespace.

[Sneezry]

@aster94 code works is basic requirement. If even the code doesn't work, the PR should not be made.

I find an answer on SO for you about why code style is important: https://stackoverflow.com/a/127955/2956469

This is not a personal project, and we will always adhere to the principle of code review.

[aster94]

This is completely no sense, i am saying that the tslint errors are due to the code style i followed and you say me that i didn t follow the code style

Again, as i wrote "i can remove these whitespaces if you really need to have tslint without errors." but this would bring to a mixed style (some function separate by a whytespace some are not)

I doubt that you ever saw the code changes 😂

[Sneezry]

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR39

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR160

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR39

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-4df1b23848899e72d52d2f373f665a33R81

These lines are added in your PR. You add spaces in these empty lines which causes the tslint error.

I wonder what code style you followed to leave these extra spaces.

[aster94]

I wonder what code style you followed to leave these extra spaces.

Seriously? I really hope you are joking with me

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR39

let's have a look to https://github.com/Microsoft/vscode-arduino/blob/master/src/arduino/arduinoSettings.ts#L38 wow a whitespace! let's see who added it c9876f9#diff-61a376a669275c4b558dffdd267a574dR38 it's you with commit c9876f9 of the pull request #620

let's see another one:

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR160

same whitespace: https://github.com/Microsoft/vscode-arduino/blob/master/src/arduino/arduinoSettings.ts#L156 try to guess who added it

do I need to continue?

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-61a376a669275c4b558dffdd267a574dR39

https://github.com/Microsoft/vscode-arduino/pull/655/files#diff-4df1b23848899e72d52d2f373f665a33R81

I know i am looking (too) sarcastic but before commenting and closing you could have given a better look to the code changes

[Sneezry]

let's have a look to https://github.com/Microsoft/vscode-arduino/blob/master/src/arduino/arduinoSettings.ts#L38 wow a whitespace! let's see who added it c9876f9#diff-61a376a669275c4b558dffdd267a574dR38 it's you with commit c9876f9 of the pull request #620

Compare with these two files:

https://raw.githubusercontent.com/Microsoft/vscode-arduino/master/src/arduino/arduinoSettings.ts

https://raw.githubusercontent.com/aster94/vscode-arduino/eed83d7e18836fd316e4aa5d18987c7dda7c6af4/src/arduino/arduinoSettings.ts

The rest are similar. I have no interest to argue with you, nor I have no time to do that.

[aster94]

you are right it's there i didn't saw it 😁