Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

add ignore board #554

Merged
merged 1 commit into from
May 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,10 @@
"arduino.disableTestingOpen": {
"type": "boolean",
"default": false
},
"arduino.ignoreBoards": {
"type": "array",
"default": []
}
}
},
Expand Down
10 changes: 10 additions & 0 deletions src/arduino/vscodeSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const configKeys = {
AUTO_UPDATE_INDEX_FILES: "arduino.autoUpdateIndexFiles",
ENABLE_USB_DETECTOIN: "arduino.enableUSBDetection",
DISABLE_TESTING_OPEN: "arduino.disableTestingOpen",
IGNORE_BOARDS: "arduino.ignoreBoards",
};

export interface IVscodeSettings {
Expand All @@ -20,6 +21,7 @@ export interface IVscodeSettings {
logLevel: string;
enableUSBDetection: boolean;
disableTestingOpen: boolean;
ignoreBoards: string[];
updateAdditionalUrls(urls: string | string[]): void;
}

Expand Down Expand Up @@ -59,6 +61,14 @@ export class VscodeSettings implements IVscodeSettings {
return this.getConfigValue<boolean>(configKeys.DISABLE_TESTING_OPEN);
}

public get ignoreBoards(): string[] {
return this.getConfigValue<string[]>(configKeys.IGNORE_BOARDS);
}

public set ignoreBoards(value: string[]) {
this.setConfigValue(configKeys.IGNORE_BOARDS, value, true);
}

public async updateAdditionalUrls(value) {
await this.setConfigValue(configKeys.ADDITIONAL_URLS, value, true);
}
Expand Down
19 changes: 17 additions & 2 deletions src/serialmonitor/usbDetector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,12 @@ export class UsbDetector {
let bd = ArduinoContext.boardManager.installedBoards.get(boardKey);
if (!bd) {
ArduinoContext.boardManager.updatePackageIndex(deviceDescriptor.indexFile).then((shouldLoadPackageContent) => {
vscode.window.showInformationMessage(`Install board package for ${deviceDescriptor.name}`, "Yes", "No").then((ans) => {
const ignoreBoards = VscodeSettings.getInstance().ignoreBoards || [];
if (ignoreBoards.indexOf(deviceDescriptor.name) >= 0) {
return;
}
vscode.window.showInformationMessage(`Install board package for ${
deviceDescriptor.name}`, "Yes", "No", "Don't ask again").then((ans) => {
if (ans === "Yes") {
ArduinoContext.arduinoApp.installBoard(deviceDescriptor.package, deviceDescriptor.architecture)
.then(() => {
Expand All @@ -88,6 +93,9 @@ export class UsbDetector {
bd = ArduinoContext.boardManager.installedBoards.get(boardKey);
this.switchBoard(bd, deviceDescriptor);
});
} else if (ans === "Don't ask again") {
ignoreBoards.push(deviceDescriptor.name);
VscodeSettings.getInstance().ignoreBoards = ignoreBoards;
}
});
});
Expand All @@ -96,11 +104,18 @@ export class UsbDetector {
if (currBoard.board !== deviceDescriptor.id
|| currBoard.platform.architecture !== deviceDescriptor.architecture
|| currBoard.getPackageName() !== deviceDescriptor.package) {
const ignoreBoards = VscodeSettings.getInstance().ignoreBoards || [];
if (ignoreBoards.indexOf(deviceDescriptor.name) >= 0) {
return;
}
vscode.window.showInformationMessage(`Detected board ${deviceDescriptor.name}. Would you like to switch to this board type?`,
"Yes", "No")
"Yes", "No", "Don't ask again")
.then((ans) => {
if (ans === "Yes") {
return this.switchBoard(bd, deviceDescriptor);
} else if (ans === "Don't ask again") {
ignoreBoards.push(deviceDescriptor.name);
VscodeSettings.getInstance().ignoreBoards = ignoreBoards;
}
});
} else {
Expand Down