This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #530 TestingOpen output on the serial monitor
This is a workaround for serial port opening test. To avoid disturbing user, I remove auto sending TestingOpen after serial port opened.
This fix may cause a small issue:
When we get serial port open event, we print a message says
Opened the serial port
. However, we cannot verify if the serial port open successfully until the user send some text by usingsendMessage
(related issue logged here: serialport/node-serialport#795).Thus, the user may see two contradictory messages after send some text in a chance, one says serial port opened, one says open serial port opened failed.