Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

lazy check for serial port opening #532

Closed
wants to merge 1 commit into from
Closed

lazy check for serial port opening #532

wants to merge 1 commit into from

Conversation

Sneezry
Copy link
Member

@Sneezry Sneezry commented Apr 17, 2018

Related issue: #530 TestingOpen output on the serial monitor

This is a workaround for serial port opening test. To avoid disturbing user, I remove auto sending TestingOpen after serial port opened.

This fix may cause a small issue:

When we get serial port open event, we print a message says Opened the serial port. However, we cannot verify if the serial port open successfully until the user send some text by using sendMessage (related issue logged here: serialport/node-serialport#795).

Thus, the user may see two contradictory messages after send some text in a chance, one says serial port opened, one says open serial port opened failed.

@Sneezry Sneezry requested review from lirenhe, yaohaizh and ihere1 April 17, 2018 05:33
@Sneezry
Copy link
Member Author

Sneezry commented Apr 17, 2018

If the user just read data from serial port, but not write data, he/she will see serial port opened successfully but not receive any data.

@Sneezry Sneezry closed this Apr 17, 2018
@Sneezry Sneezry deleted the zhe-work branch April 17, 2018 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant