This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Add autoUpdateIndexFiles option in settings #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@testforstephen, |
yaohaizh
reviewed
Mar 22, 2017
| } | ||
| const installedPlatforms = this._arduinoApp.boardManager.getInstalledPlatforms(); | ||
| for (let board of installedPlatforms) { | ||
| const libs = await this.parseBoardLibraries(board.rootBoardPath, board.architecture, librarySet); |
There was a problem hiding this comment.
Here we should use "let" instead of "const"
There was a problem hiding this comment.
don't see any bad effect for "const" in iterator loop. maybe revisit "let" and "const" later.
andxu
approved these changes
Mar 22, 2017
yaohaizh
reviewed
Mar 22, 2017
package.json
Outdated
| "arduino.autoUpdateIndexFiles": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "This option used to control whether to auto-update package_index.json or library_index.json index files or not. If true, means that each time when you open Boards Manager/Library Manager, the extension will download latest index files first. If false, means that if index files exist on local disk, then don't download again." |
There was a problem hiding this comment.
Need rephrase the description....
yaohaizh
approved these changes
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@akaroml @adashen @andxu @Eskibear @jdneo @yaohaizh