This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix bug: Search path for Library Manager is incomplete #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@testforstephen, |
andxu
approved these changes
Mar 20, 2017
yaohaizh
reviewed
Mar 20, 2017
src/common/util.ts
Outdated
| @@ -51,6 +51,24 @@ export function directoryExistsSync(dirPath: string): boolean { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * This function will implement same function as fs.readdirSync, | |||
There was a problem hiding this comment.
Grammar:
Add "the" before same and fs.readdireSync. Should be "filter out"
yaohaizh
reviewed
Mar 20, 2017
| // If lib src folder doesn't exist, then fallback to the lib root path as source folder. | ||
| sourceLib.srcPath = util.directoryExistsSync(sourceLib.srcPath) ? sourceLib.srcPath : path.join(libRoot, libDir); | ||
| const formattedName = properties.name.replace(/\s+/g, "_"); | ||
| let sourceLib = this._libraryMap.get(formattedName); |
There was a problem hiding this comment.
Can we factor out the common code pieces for add sourceLib object?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#160 Library Manager search is incomplete
@akaroml @adashen @andxu @Eskibear @jdneo @yaohaizh