This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Bundle arduino-cli with extension #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcampbell-msft
approved these changes
Feb 8, 2023
src/arduino/arduinoSettings.ts
Outdated
| // 2. Resolve arduino path from the bundled arduino-cli, if CLI support is enabled. | ||
| const bundledPath = await this.bundledArduinoCliPath(); | ||
| if (bundledPath && this._useArduinoCli && !this._commandPath) { | ||
| // The extension VSIX stipped the executable bit, so we need to set it. |
There was a problem hiding this comment.
Nit: stipped should be skipped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ships platform specific copies of arduino-cli version 0.29.0 with the extension and updates the Arduino path resolution logic to resolve to the bundled copy if
arduino.useArduinoCliistrueandarduino.pathandarduino.commandPathare unset. It also adds two notifications to guide users towards using the bundled arduino-cli.First, if the Arduino path specified in the settings can't be resolved, this notification appears when running commands.
Second, if
arduino.useArduinoCliisfalse, this notification appears even if the configuration is a valid usage of Arduino IDE.This notification is intentionally annoying with slightly aggressive wording because we'd like to stop supporting Arduino IDE. There's no way to permanently dismiss this notification without moving to arduino-cli.
Unfortunately, the second notification will appear even on first use of new installations, because
arduino.useArduinoClistill defaults tofalse. We're stuck with this behavior because if we change the default value ofarduino.useArduinoCliin this release, we'll end up breaking workflows that are intentionally using Arduino IDE but rely on the current default value.