This repository was archived by the owner on Oct 1, 2024. It is now read-only.
possible fix for #1473 #1486
Merged
possible fix for #1473 #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gcampbell-msft
commented
Mar 31, 2022
gcampbell-msft
commented
- Defaults to using the users settings in arduino.json if it's set.
- Removes the addition of the board name to create specific temp files. Instead, if the temp file already exists, clear it out so that no builds or files are corrupted.
benmcmorran
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
These changes look reasonable to me, but I'm not enough of an expert in this extension to guarantee that there aren't other unexpected side effects. Assuming you've done some manual testing, I'd also send the original issue reporter a link to the CI build to verify that the fix works for them before we merge.
Also, looks like your CI build is currently blocked on linting issues.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.