This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Don't use * activation event
#1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
approved these changes
Mar 24, 2022
|
/azp run |
|
Thanks for the contribution @BelKed! Don't mind any comments I'm making below -- I'm just trying to convince the bot to run our private CI. |
|
/azp run |
|
/azp run |
|
Just checking, would it be better to activate only on |
|
That's a good point. I was thinking that Arduino projects may include C/C++ sources in their projects, but you're right that there will always be at least one .ino file if it's an Arduino project. I'll create a follow-up PR with the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
*activation event is not a best practise. Instead, it should useonLanguage:cppor something similar.I realized that in
onCommand:arduiono.cliUploadUsingProgrammeris a typo so that's also fixed in this PR...Related to
*causesms-vscode.cpptoolsto load in every directory #1478