This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Switch from serial-monitor-cli to node-serialport #1450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
commented
Feb 9, 2022
gcampbell-msft
approved these changes
Feb 9, 2022
| @@ -124,7 +101,7 @@ export class SerialPortCtrl { | |||
| resolve(); | |||
| return; | |||
| } | |||
| this._child.stdin.write(`{"cmd": "write", "payload": "${text}"}\n`, (error) => { | |||
| this._port.write(text + "\n", (error) => { | |||
There was a problem hiding this comment.
This is the same as what we were previously writing during sendMessage, but what purpose does adding a newline serve?
There was a problem hiding this comment.
This matches existing behavior from serial-monitor-cli. While the serial-monitor-cli end of line character is technically configurable using the -e command line argument, vscode-arduino never specifies that argument so it will always have its default value of \n.
Eventually newline should be configurable to address #1324.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We keep get antivirus false positives from serial-monitor-cli, and version 10 of node-serialport now uses the Node-API so it should be stable across electron versions.
This PR should also address #1348.