This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Improve additionalUrls settings UI #1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmcmorran
force-pushed
the
dev/bemcmorr/additional-url-ui
branch
from
fddd59b to
3414715
Compare
gcampbell-msft
approved these changes
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make the "Additional URLs" go directly to the appropriate setting in the settings editor and update the settings schema so that the settings editor can render the list of additional URLs as a list instead of forcing users to edit JSON.
Internally, we still support the old comma-delimited format, so this shouldn't be a breaking change.