This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Add signing for VSIX, JS, and Windows files #1403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the extension compliant with Microsoft's signing policy. Policy states that it's not possible to sign the VS Code extension VSIX, but in practice it appears to work and still install correctly in VS Code. None of these signing changes will have any user-facing impact until microsoft/vscode-vsce#191 is resolved, but they will provide a way for users to manually verify extension authenticity.
A real-signed build failure after merging this PR is expected because the build pipeline will likely still be waiting for real-signing approval.Approval happened faster than I expected. Builds from approved sources (tags and known branches) should be real-signed now.