Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Bump to v0.4.7 #1380

Merged
merged 21 commits into from
Nov 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@ plugins:
- '@typescript-eslint'
rules: {
"no-empty": ["error", { "allowEmptyCatch": true }],
"no-unused-vars": ["error", { "args": "none" }]
"@typescript-eslint/no-unused-vars": ["error", { "args": "none" }]
}

4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
- name: preinstall
run: |
npm install -g node-gyp
npm install -g vsce
npm install -g vsce@"^1.0.0"
npm install -g gulp
- name: install
run: npm install
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
- name: preinstall
run: |
npm install -g node-gyp
npm install -g vsce
npm install -g vsce@"^1.0.0"
npm install -g gulp
- name: install
run: npm install
Expand Down
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
# Change Log
All notable changes to this project will be documented in this file.

## Version 0.4.7

- Release date: ???

### Changed

- Add support for ST-Link v3.0 [#1366](https://github.com/microsoft/vscode-arduino/pull/1366)
- Fix empty board and examples list [#1367](https://github.com/microsoft/vscode-arduino/pull/1367)
- Fix ESLint parsing for enums [#1368](https://github.com/microsoft/vscode-arduino/pull/1368)
- Fix build cwd [#1375](https://github.com/microsoft/vscode-arduino/pull/1375)
- Fix stack overflow in board configuration view [#1379](https://github.com/microsoft/vscode-arduino/pull/1379)

## Version 0.4.6

- Release date: September 29, 2021
Expand Down
11 changes: 11 additions & 0 deletions misc/debuggerUsbMapping.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,17 @@
"short_name": "stlink-2.1",
"config_file": "stlink-v2-1.cfg"
},
{
"vid": "0483",
"pid": [
"374e",
"374f",
"3753"
],
"name": "ST Link V3.0",
"short_name": "stlink-v3.0",
"config_file": "stlink-v3-0.cfg"
},
{
"pid": [
"0101",
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "vscode-arduino",
"displayName": "Arduino",
"description": "Arduino for Visual Studio Code",
"version": "0.4.6",
"version": "0.4.7-rc2",
"publisher": "vsciot-vscode",
"aiKey": "83dd2c27-6594-41d3-85a9-bdb22070eb42",
"preview": true,
Expand Down
5 changes: 1 addition & 4 deletions src/arduino/arduino.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ import { SerialMonitor } from "../serialmonitor/serialMonitor";
import { UsbDetector } from "../serialmonitor/usbDetector";
import { ProgrammerManager } from "./programmerManager";

// Not sure why eslint fails to detect usage of this enum, so disable checking.
/* eslint-disable no-unused-vars */
/**
* Supported build modes. For further explanation see the documentation
* of ArduinoApp.build().
Expand All @@ -42,7 +40,6 @@ export enum BuildMode {
UploadProgrammer = "Uploading (programmer)",
CliUploadProgrammer = "Uploading (programmer) using Arduino CLI",
}
/* eslint-enable no-unused-vars */

/**
* Represent an Arduino application based on the official Arduino IDE.
Expand Down Expand Up @@ -767,7 +764,7 @@ export class ArduinoApp {
return await util.spawn(
this._settings.commandPath,
args,
undefined,
{ cwd: ArduinoWorkspace.rootPath },
{ /*channel: arduinoChannel.channel,*/ stdout: stdoutcb, stderr: stderrcb },
).then(async () => {
const ret = await cleanup("ok");
Expand Down
2 changes: 0 additions & 2 deletions src/arduino/intellisense.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ function makeCompilerParserEngines(dc: DeviceContext) {
}

// Not sure why eslint fails to detect usage of these enums, so disable checking.
/* eslint-disable no-unused-vars */
/**
* Possible states of AnalysisManager's state machine.
*/
Expand Down Expand Up @@ -189,7 +188,6 @@ enum AnalysisEvent {
*/
AnalysisBuildDone,
}
/* eslint-enable no-unused-vars */

/**
* This class manages analysis builds for the automatic IntelliSense
Expand Down
3 changes: 0 additions & 3 deletions src/arduino/package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ export interface IBoardConfigItem {
options: IBoardConfigOption[];
}

// Not sure why eslint fails to detect usage of this enum, so disable checking.
/* eslint-disable no-unused-vars */
/**
* Return values of calls to IBoard.loadConfig() and IBoard.updateConfig().
*/
Expand Down Expand Up @@ -182,7 +180,6 @@ export enum BoardConfigResult {
*/
InvalidFormat,
}
/* eslint-enable no-unused-vars */

/**
* Interface for classes that represent an Arduino supported board.
Expand Down
3 changes: 0 additions & 3 deletions src/common/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ export const CPP_CONFIG_FILE = path.join(".vscode", "c_cpp_properties.json");
/** The name of the intellisense configuration managed by vscode-arduino. */
export const C_CPP_PROPERTIES_CONFIG_NAME = "Arduino";

// Not sure why eslint fails to detect usage of this enum, so disable checking.
/* eslint-disable no-unused-vars */
export enum LogLevel {
Info = "info",
Verbose = "verbose",
}
/* eslint-enable no-unused-vars */

export const ARDUINO_MODE: vscode.DocumentSelector = [
{ language: "cpp", scheme: "file" },
Expand Down
3 changes: 0 additions & 3 deletions src/logger/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,11 @@ import * as winston from "winston";
import TelemetryTransport from "./telemetry-transport";
import UserNotificationTransport from "./user-notification-transport";

// Not sure why eslint fails to detect usage of this enum, so disable checking.
/* eslint-disable no-unused-vars */
export enum LogLevel {
Info = "info",
Warn = "warn",
Error = "error",
}
/* eslint-enable no-unused-vars */

function FilterErrorPath(line: string): string {
if (line) {
Expand Down
2 changes: 1 addition & 1 deletion src/views/app/components/BoardConfig.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class BoardConfig extends React.Component<IBoardConfigProps, React.Props<any>> {
this.state = {};
}

public UNSAFE_componentWillMount() {
public componentWillMount() {
this.props.loadInstalledBoards();
this.props.loadConfigItems();
}
Expand Down
2 changes: 1 addition & 1 deletion src/views/app/components/BoardManager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class BoardManager extends React.Component<IBoardManagerProps, IBoardManagerStat
this.typeUpdate = this.typeUpdate.bind(this);
}

public UNSAFE_componentWillMount() {
public componentWillMount() {
this.props.loadBoardPackages(false);
}

Expand Down
9 changes: 6 additions & 3 deletions src/views/app/components/BoardSelector.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,15 @@ export default class BoardSelector extends React.Component<IBoardSelectorProps,
this.updateSelectedBoard = this.updateSelectedBoard.bind(this);
}

public render() {
if (!this.state.selectedBoard && this.props.installedBoards.length) {
public componentWillReceiveProps(nextProps) {
if (!this.state.selectedBoard && nextProps.installedBoards.length) {
this.setState({
selectedBoard: this.props.installedBoards.find((bd) => bd.isSelected),
selectedBoard: nextProps.installedBoards.find((bd) => bd.isSelected),
});
}
}

public render() {
const options = this.props.installedBoards.map((b) => {
return {
value: b.key,
Expand Down
2 changes: 1 addition & 1 deletion src/views/app/components/ExampleTreeView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class ExampleTreeView extends React.Component<IExampleViewProps, IExampleViewSta
this.onExpand = this.onExpand.bind(this);
}

public UNSAFE_componentWillMount() {
public componentWillMount() {
this.props.loadExamples();
}

Expand Down
2 changes: 1 addition & 1 deletion src/views/app/components/LibraryManager.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ class LibraryManager extends React.Component<ILibraryManagerProps, ILibraryManag
this.handleCheck = this.handleCheck.bind(this);
}

public UNSAFE_componentWillMount() {
public componentWillMount() {
this.props.loadLibraries(false);
}

Expand Down