Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Fix for #1203 Using the codepage with arduino.l4j.ini on win32 #1271

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

two-pack
Copy link
Contributor

Fix for #1203.

Arduino specifies UTF-8 on arduino.l4j.ini or arduino-debug.l4j.ini. See the issue.
So before using chcp command for getting codepage, try to get the codepage from the configure.

I get clean output with this PR on following environment.

  • Windows 10 Pro 20H2 19042.985
  • Arduino 1.8.15
  • Visual Studio Code 1.56.2 (system setup)
    054a9295330880ed74ceaedda236253b4f39a335
  • Electron: 12.0.4
  • Chrome: 89.0.4389.114
  • Node.js: 14.16.0
  • V8: 8.9.255.24-electron.0
  • OS: Windows_NT x64 10.0.19042

@ghost
Copy link

ghost commented May 23, 2021

CLA assistant check
All CLA requirements met.

@two-pack
Copy link
Contributor Author

two-pack commented Sep 3, 2021

I think #1237 is better solution. I close this.

@two-pack
Copy link
Contributor Author

two-pack commented Sep 5, 2021

I think #1237 is better solution. I close this.

I checked again, PR #1237 specifies the code page as fixed to UTF-8, so the correct characters are output.
It isn't better when arduino.l4j.ini is changed. So I reopen this PR.

@two-pack two-pack reopened this Sep 5, 2021
@benmcmorran benmcmorran changed the base branch from master to dev January 10, 2022 20:22
Copy link
Member

@benmcmorran benmcmorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me.

@benmcmorran benmcmorran merged commit 466a669 into microsoft:main Jan 13, 2022
@two-pack two-pack deleted the use-l4j-encoding branch January 14, 2022 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants