This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Unify verify, upload, and uploadUsingProgrammer to a single code path #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several cases in which serial monitor and USB detection would not be properly restored, including early outs and build failures. Move restoration to a finally clause to guarantee the restore path will be called.
Also reduce scope/duration that serial monitor is disabled to only include build, but not prebuild
|
#1183 unified all the build functions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge these three functions into a single code path. This reduces maintainence & bugs that resulting from minor variances between the 3 paths.