Skip to content

add performanceservertiming #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2021
Merged

add performanceservertiming #984

merged 1 commit into from
Mar 11, 2021

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Feb 25, 2021

In the hopes of getting a discussion going around PerformanceServerTiming this implements the basic types as specified in the WD spec.

From the contributor guidelines:

  • Does the new objects or fields show up in mdn/browser-compat-data? If not, it's likely too soon. (See browser-compat-data)
  • Is the IDL source from WHATWG? (No, W3C)
    • Are the additions available in at least two of Firefox, Safari and Chromium?
  • Is the IDL source from W3C?
    • What stage of the W3C process is the proposal for these changes: We aim for Proposed recommendation, but can accept Candidate recommendation for stable looking proposals. (Working Draft)
    • If it's at Working draft the additions available in all three of Firefox, Safari and Chromium (Not Safari yet, but Chrome, Edge & Firefox)
  • Could any types added at the global scope have naming conflicts? (Doubtful unless someone is polyfilling these?)
  • Are the new features going to be used by a lot of people? (We'd like to use this on GitHub 🤷)

From the browser compat table on mdn this API is available in Firefox 61, Chrome 65, Edge 79

browser compat table

@keithamus keithamus requested a review from sandersn as a code owner February 25, 2021 12:23
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the well written PR description - we should consider making a PR template with that?

@sandersn sandersn merged commit 1fd97d1 into microsoft:master Mar 11, 2021
@keithamus keithamus deleted the patch-3 branch March 14, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants