Skip to content

Add beforeinput event to GlobalEventHandlersEventMap #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Add beforeinput event to GlobalEventHandlersEventMap #964

merged 2 commits into from
Dec 21, 2020

Conversation

marijnh
Copy link
Contributor

@marijnh marijnh commented Dec 15, 2020

"beforeinput", as defined here and implemented in Chrome for a long time and Firefox nightly recently, was missing from the event types.

This (trivially) conflicts with #949 since it adds to the same JSON structure in the same place. It'd be wonderful if someone could merge the both of them (since these don't seem controversial).

@marijnh marijnh requested a review from sandersn as a code owner December 15, 2020 12:36
@orta
Copy link
Contributor

orta commented Dec 21, 2020

Looks like caniuse says it's in chrome and safari, and if it's in a FF nightly, then I'm good to have this in 👍🏻

@orta orta merged commit 77813e6 into microsoft:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants