Skip to content

Correct type of Window.frameElement #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Correct type of Window.frameElement #956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9aa63c4
Correct type of Window.frameElement.
djcsdy Nov 21, 2020
19027d1
Replace "override-type" with "nullable": 1
djcsdy Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18481,7 +18481,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
readonly event: Event | undefined;
/** @deprecated */
readonly external: External;
readonly frameElement: Element;
readonly frameElement: Element | null;
readonly frames: Window;
readonly history: History;
readonly innerHeight: number;
Expand Down Expand Up @@ -19520,7 +19520,7 @@ declare var document: Document;
declare var event: Event | undefined;
/** @deprecated */
declare var external: External;
declare var frameElement: Element;
declare var frameElement: Element | null;
declare var frames: Window;
declare var history: History;
declare var innerHeight: number;
Expand Down
3 changes: 3 additions & 0 deletions inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,9 @@
"override-type": "Event | undefined",
"deprecated": 1
},
"frameElement": {
"nullable": 1
},
"location": {
"read-only": 0
},
Expand Down