Skip to content

Fix PermissionName for clipboard #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2020
Merged

Fix PermissionName for clipboard #930

merged 1 commit into from
Dec 21, 2020

Conversation

zhouhanseng
Copy link
Contributor

@zhouhanseng zhouhanseng commented Oct 22, 2020 •
edited
Loading

@zhouhanseng zhouhanseng requested a review from sandersn as a code owner October 22, 2020 12:27
@ghost
Copy link

ghost commented Oct 22, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@zhouhanseng zhouhanseng mentioned this pull request Oct 22, 2020
Merged
@zhouhanseng zhouhanseng force-pushed the hancheng.zhou/fix-permission-name-clipboard branch from 3e971a7 to fb2dda0 Compare October 22, 2020 12:42
@Jack-Works Jack-Works mentioned this pull request Oct 23, 2020
Closed
@saschanaz
Copy link
Contributor

saschanaz commented Oct 24, 2020 •
edited
Loading

LGTM as is, but if you could run npm run fetch-idl Permissions && npm run build && npm run baseline-accept and commit it then it would be greater. Thanks!

@zhouhanseng zhouhanseng force-pushed the hancheng.zhou/fix-permission-name-clipboard branch from fb2dda0 to 0e4f1b0 Compare October 24, 2020 05:00
@zhouhanseng
Copy link
Contributor Author

@saschanaz done thx!

@Tedko
Copy link

Tedko commented Nov 5, 2020

hi @saschanaz any updt?

@saschanaz
Copy link
Contributor

saschanaz commented Nov 5, 2020 •
edited
Loading

(Waiting a review from TS team...)

@orta
Copy link
Contributor

orta commented Dec 21, 2020

👍🏻

@orta orta merged commit e4b51b6 into microsoft:master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wait for TypeScript-DOM-lib-generator#930 merged.
4 participants
@zhouhanseng @saschanaz @Tedko @orta